From 09e26c37de7e7227d856ffe15c9554af36b50c58 Mon Sep 17 00:00:00 2001 From: Alexander Foremny Date: Thu, 14 Mar 2024 07:07:28 +0100 Subject: review: request-changes feature/review --- app/Git/CommitHash.hs | 5 ----- 1 file changed, 5 deletions(-) (limited to 'app/Git') diff --git a/app/Git/CommitHash.hs b/app/Git/CommitHash.hs index 28aa738..0caecf4 100644 --- a/app/Git/CommitHash.hs +++ b/app/Git/CommitHash.hs @@ -27,11 +27,6 @@ toText (Commit hash) = Just hash toTextUnsafe :: CommitHash -> T.Text toTextUnsafe (Commit hash) = hash toTextUnsafe _ = error "toTextUnsafe: WorkingDir" --- ^ REVIEW Why is this unsafe? --- --- REVIEW Because it is a partial function. --- --- RESOLVED instance P.Render CommitHash where render = P.render . P.Detailed -- cgit v1.2.3