diff options
| author |  Alexander Foremny <aforemny@posteo.de> | 2024-03-14 07:07:28 +0100 |
|---|---|---|
| committer | Alexander Foremny <aforemny@posteo.de> | 2024-03-14 07:07:45 +0100 |
| commit | 09e26c37de7e7227d856ffe15c9554af36b50c58 (patch) | |
| tree | 553a527ff19f5ef105cbc2f026284e75fa5900db | |
| parent | 8dcace960b25813b00e5f77be25aa7db57851f79 (diff) | |
review: request-changes feature/review
| -rw-r--r-- | app/Git.hs | 6 | ||||
| -rw-r--r-- | app/Git/CommitHash.hs | 5 | ||||
| -rw-r--r-- | app/Main.hs | 9 |
3 files changed, 0 insertions, 20 deletions
@@ -97,12 +97,6 @@ readTextFileOfText = readTextFileOf LT.readFile LT.decodeUtf8 readTextFileOfBS :: CommitHash -> FilePath -> IO LB.ByteString readTextFileOfBS = readTextFileOf LB.readFile id --- REVIEW Suggestion: we could use `id` instead of `\x -> x` --- --- REVIEW OK! --- --- RESOLVED - readTextFileOf :: (FilePath -> IO a) -> (LB.ByteString -> a) -> CommitHash -> FilePath -> IO a readTextFileOf readFile _ WorkingTree filePath = catch diff --git a/app/Git/CommitHash.hs b/app/Git/CommitHash.hs index 28aa738..0caecf4 100644 --- a/app/Git/CommitHash.hs +++ b/app/Git/CommitHash.hs @@ -27,11 +27,6 @@ toText (Commit hash) = Just hash toTextUnsafe :: CommitHash -> T.Text toTextUnsafe (Commit hash) = hash toTextUnsafe _ = error "toTextUnsafe: WorkingDir" --- ^ REVIEW Why is this unsafe? --- --- REVIEW Because it is a partial function. --- --- RESOLVED instance P.Render CommitHash where render = P.render . P.Detailed diff --git a/app/Main.hs b/app/Main.hs index c35d827..f9fedea 100644 --- a/app/Main.hs +++ b/app/Main.hs @@ -552,11 +552,6 @@ perCommitArg :: O.Parser Bool perCommitArg = O.switch ( O.long "per-commit" - -- REVIEW Maybe a short variant would be nice, e.g. '-c'. - -- - -- REVIEW Sure!, but I don't want to block on this, and I don't think this warrants a tracking issue. - -- - -- RESOLVED <> O.help "Review commits individually. (Default: review combined patches)" ) @@ -635,10 +630,6 @@ main = do plan <- R.formulatePlan perCommit baseBranch featureBranch R.commitReview plan . A.Patch . concat =<< mapM R.reviewStep (NE.toList plan.steps) - -- REVIEW Why is withReviewing in the Status module and not the Review - -- module? - -- - -- RESOLVED `Status` has been dropped in this commit Options {colorize, noPager, width, command = List {sort, filters, files, group = Just group, closed}} -> do ungroupedIssues <- I.applySorts sort |