diff options
| author |  Alexander Foremny <aforemny@posteo.de> | 2024-03-13 06:16:50 +0100 |
|---|---|---|
| committer | Alexander Foremny <aforemny@posteo.de> | 2024-03-14 07:07:45 +0100 |
| commit | 7f0066cafd2a91959ef618ef8342524ca30a328f (patch) | |
| tree | 6a9194edb4c3f48401d6da35a09942aa77920148 /app | |
| parent | e06061a2d5717bee9b0b4fcaf72d3c79923e4016 (diff) | |
review: request-changes feature/review
Diffstat (limited to 'app')
| -rw-r--r-- | app/Git.hs | 6 | ||||
| -rw-r--r-- | app/Git/CommitHash.hs | 6 |
2 files changed, 10 insertions, 2 deletions
@@ -95,8 +95,12 @@ readTextFileOfText :: CommitHash -> FilePath -> IO LT.Text readTextFileOfText = readTextFileOf LT.readFile LT.decodeUtf8 readTextFileOfBS :: CommitHash -> FilePath -> IO LB.ByteString -readTextFileOfBS = readTextFileOf LB.readFile (\x -> x) +readTextFileOfBS = readTextFileOf LB.readFile id -- REVIEW Suggestion: we could use `id` instead of `\x -> x` +-- +-- REVIEW OK! +-- +-- RESOLVED readTextFileOf :: (FilePath -> IO a) -> (LB.ByteString -> a) -> CommitHash -> FilePath -> IO a readTextFileOf readFile _ WorkingTree filePath = diff --git a/app/Git/CommitHash.hs b/app/Git/CommitHash.hs index c53e2d8..28aa738 100644 --- a/app/Git/CommitHash.hs +++ b/app/Git/CommitHash.hs @@ -27,8 +27,12 @@ toText (Commit hash) = Just hash toTextUnsafe :: CommitHash -> T.Text toTextUnsafe (Commit hash) = hash toTextUnsafe _ = error "toTextUnsafe: WorkingDir" +-- ^ REVIEW Why is this unsafe? +-- +-- REVIEW Because it is a partial function. +-- +-- RESOLVED --- REVIEW Why is this unsafe? instance P.Render CommitHash where render = P.render . P.Detailed |